SethFalco/nodejs-microbenchmarks
Watch
1
Code Issues Pull requests Projects Releases Packages Activity Actions

ci: add test and lint tasks #1

Merged
Ghost merged 0 commits from refs/pull/1/head into main 2025-05-24 23:57:07 +01:00
Conversation 12 Commits - Files changed -
Ghost commented 2025-05-23 21:56:22 +01:00 (Migrated from codeberg.org)
Copy link

Chores

  • Enables corepack and upgrades to Yarn Berry.
  • Adds ESLint to the project and applies formatting.
  • Adds TypeScript to the project to ensure types and formatting are valid.

New Microbenchmark

  • Adds a microbenchmark for getting a string with today's date. (Prompted from a code review during client work.)
  • Adds a microbenchmark for comparing CSS specificity. In SVGO, we copied the implementation from an upstream library, but I noticed they they switched their implementation too. I put both the old and new implementation in a benchmark to see which is faster.

Fixes

There was an issue where it's impossible to tell if I'm passing an array because we want to pass multiple arguments, or if we want to pass a single argument that is an array. To resolve this, we now just always pass an array of arguments. So an argument that is an array is just an array in that array.

It'll a little cumbersome, but is much more consistent and easier to write benchmarks against.

## Chores * Enables corepack and upgrades to Yarn Berry. * Adds ESLint to the project and applies formatting. * Adds TypeScript to the project to ensure types and formatting are valid. ## New Microbenchmark * Adds a microbenchmark for getting a string with today's date. (Prompted from a code review during client work.) * Adds a microbenchmark for comparing CSS specificity. In SVGO, we copied the implementation from an upstream library, but I noticed they they switched their implementation too. I put both the old and new implementation in a benchmark to see which is faster. ## Fixes There was an issue where it's impossible to tell if I'm passing an array because we want to pass multiple arguments, or if we want to pass a single argument that is an array. To resolve this, we now just always pass an array of arguments. So an argument that is an array is just an array in that array. It'll a little cumbersome, but is much more consistent and easier to write benchmarks against.
Ghost commented 2025-05-23 21:57:09 +01:00 (Migrated from codeberg.org)
Copy link

added 1 commit

  • a0644c8a - ci: add test and lint tasks

Compare with previous version

added 1 commit <ul><li>a0644c8a - ci: add test and lint tasks</li></ul> [Compare with previous version](/SethFalco/nodejs-microbenchmarks/-/merge_requests/1/diffs?diff_id=1368284968&start_sha=83e502581001b587e45a6afd97ac20fa0cdd2896)
Ghost commented 2025-05-23 22:00:11 +01:00 (Migrated from codeberg.org)
Copy link

added 1 commit

  • 53b94da6 - ci: add test and lint tasks

Compare with previous version

added 1 commit <ul><li>53b94da6 - ci: add test and lint tasks</li></ul> [Compare with previous version](/SethFalco/nodejs-microbenchmarks/-/merge_requests/1/diffs?diff_id=1368286469&start_sha=a0644c8af18cb92939f7949196aa2d0ef5c669e6)
Ghost commented 2025-05-23 22:06:56 +01:00 (Migrated from codeberg.org)
Copy link

added 1 commit

  • 89dc9ecf - ci: add test and lint tasks

Compare with previous version

added 1 commit <ul><li>89dc9ecf - ci: add test and lint tasks</li></ul> [Compare with previous version](/SethFalco/nodejs-microbenchmarks/-/merge_requests/1/diffs?diff_id=1368290215&start_sha=53b94da691ced3a041064bb6d687ed70291aed77)
Ghost commented 2025-05-23 22:09:28 +01:00 (Migrated from codeberg.org)
Copy link

added 1 commit

  • 8dc13efe - ci: add test and lint tasks

Compare with previous version

added 1 commit <ul><li>8dc13efe - ci: add test and lint tasks</li></ul> [Compare with previous version](/SethFalco/nodejs-microbenchmarks/-/merge_requests/1/diffs?diff_id=1368291656&start_sha=89dc9ecf81723ed258d728bcc0f047e40c461fa2)
Ghost commented 2025-05-23 22:13:07 +01:00 (Migrated from codeberg.org)
Copy link

added 3 commits

  • abbc5ffb - ci: add test and lint tasks
  • 2e0eda8d - docs: reword readme and refer to yarn instead of npm
  • f471d370 - chore: always use array for arguments insert of inferring

Compare with previous version

added 3 commits <ul><li>abbc5ffb - ci: add test and lint tasks</li><li>2e0eda8d - docs: reword readme and refer to yarn instead of npm</li><li>f471d370 - chore: always use array for arguments insert of inferring</li></ul> [Compare with previous version](/SethFalco/nodejs-microbenchmarks/-/merge_requests/1/diffs?diff_id=1368293519&start_sha=8dc13efe54b184e50769ec5d86e594c534bf0989)
Ghost commented 2025-05-23 22:18:12 +01:00 (Migrated from codeberg.org)
Copy link

added 3 commits

  • fe15ceb1 - ci: add test and lint tasks
  • b881d8f9 - docs: reword readme and refer to yarn instead of npm
  • c1e58788 - chore: always use array for arguments insert of inferring

Compare with previous version

added 3 commits <ul><li>fe15ceb1 - ci: add test and lint tasks</li><li>b881d8f9 - docs: reword readme and refer to yarn instead of npm</li><li>c1e58788 - chore: always use array for arguments insert of inferring</li></ul> [Compare with previous version](/SethFalco/nodejs-microbenchmarks/-/merge_requests/1/diffs?diff_id=1368296202&start_sha=f471d370d87c1710685528d0f42d04596bc3c8cc)
Ghost commented 2025-05-23 22:31:33 +01:00 (Migrated from codeberg.org)
Copy link

added 1 commit

  • ee6f93ab - chore: upgrade eslint and enforce more rules

Compare with previous version

added 1 commit <ul><li>ee6f93ab - chore: upgrade eslint and enforce more rules</li></ul> [Compare with previous version](/SethFalco/nodejs-microbenchmarks/-/merge_requests/1/diffs?diff_id=1368303628&start_sha=c1e587889f55a8a0670a3ced3ddecc44c812359c)
Ghost commented 2025-05-23 22:55:29 +01:00 (Migrated from codeberg.org)
Copy link

added 1 commit

  • cf7633c0 - feat: add support for not args in arefunctionsequal

Compare with previous version

added 1 commit <ul><li>cf7633c0 - feat: add support for not args in arefunctionsequal</li></ul> [Compare with previous version](/SethFalco/nodejs-microbenchmarks/-/merge_requests/1/diffs?diff_id=1368313357&start_sha=ee6f93ab83bf28d90fb9279589e60019414f585f)
Ghost commented 2025-05-23 23:36:46 +01:00 (Migrated from codeberg.org)
Copy link

added 1 commit

  • ce49c198 - chore: improve benchmark setup

Compare with previous version

added 1 commit <ul><li>ce49c198 - chore: improve benchmark setup</li></ul> [Compare with previous version](/SethFalco/nodejs-microbenchmarks/-/merge_requests/1/diffs?diff_id=1368328970&start_sha=cf7633c0259dad7cbd88f693483aed5f79afc0e7)
Ghost commented 2025-05-24 15:41:52 +01:00 (Migrated from codeberg.org)
Copy link

added 1 commit

  • 56bcb850 - chore: improve benchmark setup

Compare with previous version

added 1 commit <ul><li>56bcb850 - chore: improve benchmark setup</li></ul> [Compare with previous version](/SethFalco/nodejs-microbenchmarks/-/merge_requests/1/diffs?diff_id=1368522936&start_sha=ce49c198f0178103e166c216047be44c8e349d89)
Ghost commented 2025-05-24 23:51:31 +01:00 (Migrated from codeberg.org)
Copy link

added 1 commit

  • a7319f55 - chore: improve benchmark setup

Compare with previous version

added 1 commit <ul><li>a7319f55 - chore: improve benchmark setup</li></ul> [Compare with previous version](/SethFalco/nodejs-microbenchmarks/-/merge_requests/1/diffs?diff_id=1368596072&start_sha=56bcb8503bf21b4c779845660c8fb97cce873a87)
Ghost commented 2025-05-24 23:57:07 +01:00 (Migrated from codeberg.org)
Copy link

mentioned in commit e405da3f76

mentioned in commit e405da3f76882097bc767f44ed0db66e303e24f3
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
SethFalco/nodejs-microbenchmarks!1
No description provided.