SethFalco/commandler
SethFalco/commandler
Watch
1
Code Issues 44 Pull requests Projects Releases Packages Activity Actions

Exception before ActionEvent is Created Prevents Message #94

New issue
Open
opened 2020-06-02 04:03:26 +01:00 by Ghost · 0 comments
Ghost commented 2020-06-02 04:03:26 +01:00 (Migrated from codeberg.org)
Copy link

Feature Request

Sub-Project

  • core

Description

It should be possible to send messages without having the full ActionEvent object. Currently, the ActionEvent is used in many places to build or actually send messages, but exceptions can occur during the creation of the ActionEvent which prevents it from existing.

However, if failing to build the ActionEvent causes an exception, we should still be able to deliver a message to user, this won't work since to send a message to users, we need the ActionEvent.

Expected Behavior

Either exceptions should be handled differently, where the ActionEvent can instead have reportable problems in a list, or we need a lighter object which is a more flexible to use in the Request Scope context to send messages even when the ActionEvent isn't constructed.

# Feature Request <!-- If you feel a heading is irrelevant, just leave it empty or remove it. --> ## Sub-Project <!-- Can you specify which sub-project(s) this is relevant to? If you aren't sure, or this is a proposal for a new sub-project, you can delete this. --> * core ## Description <!-- Explain what this is about, try to use full sentences, and make your point clear. --> It should be possible to send messages without having the full `ActionEvent` object. Currently, the `ActionEvent` is used in many places to build or actually send messages, but exceptions can occur during the creation of the `ActionEvent` which prevents it from existing. However, if failing to build the `ActionEvent` causes an exception, we should still be able to deliver a message to user, this won't work since to send a message to users, we need the `ActionEvent`. ## Expected Behavior <!-- What were you expecting to happen instead of this? --> Either exceptions should be handled differently, where the `ActionEvent` can instead have reportable problems in a list, or we need a lighter object which is a more flexible to use in the Request Scope context to send messages even when the `ActionEvent` isn't constructed.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
i18n
4.0.1
Labels
Clear labels   
bug
Something that's not working as intended in an existing project's functionality.

  
feature-request
A brand new feature for an existing project.

  
upstream
Should be resolved through an upstream contribution.

No labels
bug
feature-request
upstream
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
SethFalco/commandler#94
No description provided.