SethFalco/commandler
SethFalco/commandler
Watch
1
Code Issues 44 Pull requests Projects Releases Packages Activity Actions

Commandler MetaController Adapter Hardcodes Aliases #107

New issue
Open
opened 2020-06-13 02:02:35 +01:00 by Ghost · 0 comments
Ghost commented 2020-06-13 02:02:35 +01:00 (Migrated from codeberg.org)
Copy link

Improvement

Sub-Project

  • core

Description

The MetaControllerAdapter currently has logic in it which assumes the StandardDispatcher is in use, namely it knows what "aliases" are.

The adapter should have no knowledge of aliases, and should instead somehow refer to the properties of the object to determine this, for example through an identifiable value on the component properties.

# Improvement <!-- If you feel a heading is irrelevant, just leave it empty or remove it. --> ## Sub-Project <!-- Can you specify which sub-project(s) this is relevant to? If you aren't sure, or this is a proposal for a new sub-project, you can delete this. --> * core ## Description <!-- Explain what this is about, try to use full sentences, and make your point clear. --> The `MetaControllerAdapter` currently has logic in it which assumes the `StandardDispatcher` is in use, namely it knows what "aliases" are. The adapter should have no knowledge of aliases, and should instead somehow refer to the properties of the object to determine this, for example through an `identifiable` value on the component properties.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
i18n
4.0.1
Labels
Clear labels   
bug
Something that's not working as intended in an existing project's functionality.

  
feature-request
A brand new feature for an existing project.

  
upstream
Should be resolved through an upstream contribution.

No labels
bug
feature-request
upstream
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
SethFalco/commandler#107
No description provided.